ARROW-15775 [R] Clean up as.* methods to use build_expr() #12563
Conversation
There was a problem hiding this comment.
These look great, thanks! Would it be worth it to add a test or two for the behavior that this enables? You don't need to be super exhaustive and test all the possible combinations, but having at least one test for as.character(1), as.double("1.1"), as.integer("1"), etc. would be nice to catch if we break this in the future.
|
Benchmark runs are scheduled for baseline = 7aecc83 and contender = 5772d65. 5772d65 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
build_expr()handles the conversion of the inputs toArrayorScalar.#12433 (comment)