Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15847: [Python] Building with Parquet but without Parquet encryption fails #12565

Closed
wants to merge 7 commits into from
Closed

ARROW-15847: [Python] Building with Parquet but without Parquet encryption fails #12565

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77c8f06
test build with encryption turned off
jorisvandenbossche Mar 4, 2022
f5a5cda
fix target_link_libraries for parquet encryption
jorisvandenbossche Mar 4, 2022
fd43be2
Revert "test build with encryption turned off"
jorisvandenbossche Mar 4, 2022
4fef0d5
disable parquet encryption in the pandas nightly builds
jorisvandenbossche Mar 8, 2022
4d93ea4
Merge remote-tracking branch 'upstream/master' into parquet-encryption
jorisvandenbossche Mar 8, 2022
91c2870
restrict to pandas latest
jorisvandenbossche Mar 8, 2022
54f648f
invert cache leaf check
jorisvandenbossche Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/scripts/python_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export PYARROW_WITH_FLIGHT=${ARROW_FLIGHT:-OFF}
export PYARROW_WITH_PLASMA=${ARROW_PLASMA:-OFF}
export PYARROW_WITH_GANDIVA=${ARROW_GANDIVA:-OFF}
export PYARROW_WITH_PARQUET=${ARROW_PARQUET:-OFF}
export PYARROW_WITH_PARQUET_ENCRYPTION=${ARROW_PARQUET:-OFF}
export PYARROW_WITH_PARQUET_ENCRYPTION=${PARQUET_REQUIRE_ENCRYPTION:-OFF}
export PYARROW_WITH_DATASET=${ARROW_DATASET:-OFF}

export PYARROW_PARALLEL=${n_jobs}
Expand Down
1 change: 1 addition & 0 deletions dev/tasks/tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,6 +1392,7 @@ tasks:
PYTHON: "{{ python_version }}"
PANDAS: "{{ pandas_version }}"
NUMPY: "{{ numpy_version }}"
PARQUET_REQUIRE_ENCRYPTION: "OFF"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this just for one of these builds, not all of them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. I suggest to remove cache_leaf jinja variable and just set flags: --no-leaf-cache for all cases.

{% if cache_leaf %}
# use the latest pandas release, so prevent reusing any cached layers
flags: --no-leaf-cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for the record, isn't this condition inverted? In the parameters, cache_leaf is true for the fixed pandas version (0.24)...

@kszucs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. I suggest to remove cache_leaf jinja variable and just set flags: --no-leaf-cache for all cases.

I just inverted the check, but can also remove it altogether. I assume the cache is still useful for the one build with fixed pandas version?

Expand Down
4 changes: 3 additions & 1 deletion python/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,9 @@ endif()

if(PYARROW_BUILD_PARQUET)
target_link_libraries(_parquet PRIVATE ${PARQUET_LINK_LIBS})
target_link_libraries(_parquet_encryption PRIVATE ${PARQUET_LINK_LIBS})
if(PYARROW_BUILD_PARQUET_ENCRYPTION)
target_link_libraries(_parquet_encryption PRIVATE ${PARQUET_LINK_LIBS})
endif()
endif()

if(PYARROW_BUILD_PLASMA)
Expand Down