Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-15489: [R] Expand RecordBatchReader usability #12567

Closed
wants to merge 1 commit into from

Conversation

nealrichardson
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 4, 2022

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one very minor comment.

Comment on lines +174 to +179
expect_output(
print(reader),
"RecordBatchStreamReader
x: int32
y: string"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will say, this kind of test is a good usecase for expect_snapshot(). We don't need to change it, but it makes looking at the output much nicer than dealing with embedded newlines + tabs.

@jonkeane jonkeane closed this in 5bd9943 Mar 21, 2022
@ursabot
Copy link

ursabot commented Mar 21, 2022

Benchmark runs are scheduled for baseline = b0d6e27 and contender = 5bd9943. 5bd9943 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.54% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.36%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@nealrichardson nealrichardson deleted the add-rbr-methods branch March 21, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants