Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15890: [CI][Python] Use venv instead of virtualenv #12592

Closed
wants to merge 3 commits into from
Closed

ARROW-15890: [CI][Python] Use venv instead of virtualenv #12592

wants to merge 3 commits into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Mar 9, 2022

No description provided.

@pitrou
Copy link
Member Author

pitrou commented Mar 9, 2022

@github-actions crossbow submit wheel-macos*

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Revision: aab4eeb

Submitted crossbow builds: ursacomputing/crossbow @ actions-1735

Task Status
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp310-universal2 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-big-sur-cp39-universal2 Github Actions
wheel-macos-high-sierra-cp310-amd64 Github Actions
wheel-macos-high-sierra-cp37-amd64 Github Actions
wheel-macos-high-sierra-cp38-amd64 Github Actions
wheel-macos-high-sierra-cp39-amd64 Github Actions
wheel-macos-mavericks-cp310-amd64 Github Actions
wheel-macos-mavericks-cp37-amd64 Github Actions
wheel-macos-mavericks-cp38-amd64 Github Actions
wheel-macos-mavericks-cp39-amd64 Github Actions

@pitrou pitrou marked this pull request as ready for review March 9, 2022 15:29
@pitrou pitrou changed the title [Python] Use venv instead of virtualenv ARROW-15890: [CI][Python] Use venv instead of virtualenv Mar 9, 2022
@pitrou pitrou requested a review from kszucs March 9, 2022 15:30
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

https://issues.apache.org/jira/browse/ARROW-15890

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

pitrou
pitrou commented Mar 9, 2022
View reviewed changes
python/examples/minimal_build/README.md
@@ -24,32 +24,32 @@ an eye toward maximum portability across different Linux distributions. This
may help for contributors debugging build issues caused by their local
environments.

## Fedora 31
## Fedora 35
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we should perhaps test those minimal builds as part of our nightly builds, but that's outside the scope of this PR.

@kszucs
Copy link
Member

kszucs commented Mar 9, 2022

@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Revision: 0e680ad

Submitted crossbow builds: ursacomputing/crossbow @ actions-1740

Task Status
wheel-macos-big-sur-cp39-universal2 Github Actions

@kszucs
Copy link
Member

kszucs commented Mar 9, 2022

@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Revision: 5335dad

Submitted crossbow builds: ursacomputing/crossbow @ actions-1741

Task Status
wheel-macos-big-sur-cp39-universal2 Github Actions

@kszucs
Copy link
Member

kszucs commented Mar 9, 2022

@github-actions crossbow wheel-macos-big-sur-cp310-universal2

@github-actions
Copy link

github-actions bot commented Mar 9, 2022 

No such command 'wheel-macos-big-sur-cp310-universal2'.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/1958684281```

@kszucs
Copy link
Member

kszucs commented Mar 9, 2022

@github-actions crossbow submit wheel-macos-big-sur-cp310-universal2

@kszucs
Copy link
Member

kszucs commented Mar 9, 2022

Also resolves https://issues.apache.org/jira/browse/ARROW-15891

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Revision: 5335dad

Submitted crossbow builds: ursacomputing/crossbow @ actions-1742

Task Status
wheel-macos-big-sur-cp310-universal2 Github Actions

kszucs
kszucs approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Antoine!

@kszucs
Copy link
Member

kszucs commented Mar 9, 2022

The remaining failures are due to a failing test case test_debug_memory_pool_disabled which is unrelated to this PR.

@pitrou pitrou closed this in 875af62 Mar 9, 2022
@pitrou pitrou deleted the python-venv branch March 9, 2022 17:48
@ursabot
Copy link

ursabot commented Mar 9, 2022 •
edited

Benchmark runs are scheduled for baseline = 1b77e6d and contender = 875af62. 875af62 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.92% ⬆️0.04%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kszucs kszucs kszucs approved these changes

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pitrou @kszucs @ursabot