-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14943: [R] Bindings for lubridate's ddays, dhours, dminutes, dmonths, dweeks, dyears #12610
Conversation
This PR should be updated to use |
Left the bindings as were and decided not to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you! I just suggested a few changes to match the style of other default arguments in this file.
Thanks for reviewing @paleolimbot! I should have noticed I was still in Python land ... 🤦♀️ :) |
I added the text to the News.md in #12855. Also got quite some linter corrections when running |
All good! I'm new to how development in the arrow R package works, but I think style changes that are outside the scope of the function that is getting added/modified should be a separate PR. I've never used |
@AlenkaF there seem to be a few failing tests on windows, are they related to the PR? |
Oh, yes, they are related. Will have a look, thanks! |
Looking good. One small suggestion. Thanks for tackling the cyclomatic complexity. |
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all the work! @thisisnic @jonkeane would you mind having a look and merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments resolved, tests pass, and values used match those in lubridate, so looks good to me!
Benchmark runs are scheduled for baseline = a63ee07 and contender = 69c28de. 69c28de is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.