-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15958: [Java][Docs] Improve and document StackTrace #12656
Conversation
Should we move this forward? @lwhite1 Could you take a look? |
* <p>Most information will only be present if BaseAllocator.DEBUG is true. | ||
* | ||
*/ | ||
public void print(StringBuilder sb, int indent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really useful at closed with outstanding buffers allocated.
Could it be possible to show this error log if -Darrow.memory.debug.allocator=true
is enabled? It means get this log implicitly and not needed to call print
method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already happens if you enable the TRACE log level for org.apache.arrow.memory.BaseAllocator
. I'll update the docs with an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I'll open PRs to bump the timeout on the docs build (looks like we're getting close to the current 30 minutes) and fix some of those Sphinx warnings I'm seeing
|
This can be useful to identify the origin of a leaked buffer.
While there's a "public" API, it wasn't actually usable because it has a parameter of package-private type. This adds an overload that doesn't take that parameter so the API is actually usable.