Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-15984: [C++] Change RecordBatchReader API to use Result<> #12678

Closed
wants to merge 13 commits into from
Closed

ARROW-15984: [C++] Change RecordBatchReader API to use Result<> #12678

wants to merge 13 commits into from

Conversation

zagto
Copy link
Contributor

@zagto zagto commented Mar 21, 2022

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-15984

@pitrou
Copy link
Member

pitrou commented Mar 22, 2022

Can you take a look at the C/GLib CI failure here? https://github.com/apache/arrow/runs/5645554934?check_suite_focus=true

Also, usage in PyArrow should probably be migrated also, do you want to do it yourself? (otherwise, someone else can)
https://github.com/apache/arrow/blob/master/python/pyarrow/ipc.pxi#L609

pitrou
pitrou reviewed Mar 22, 2022
View reviewed changes
cpp/src/arrow/testing/gtest_util.h Outdated Show resolved Hide resolved
cpp/src/arrow/record_batch_test.cc Show resolved Hide resolved
@zagto
Copy link
Contributor Author

zagto commented Mar 22, 2022

Can you take a look at the C/GLib CI failure here? https://github.com/apache/arrow/runs/5645554934?check_suite_focus=true

Also, usage in PyArrow should probably be migrated also, do you want to do it yourself? (otherwise, someone else can)
https://github.com/apache/arrow/blob/master/python/pyarrow/ipc.pxi#L609

regarding Python and GLib bindings, I'll try doing these myself

@zagto zagto requested a review from pitrou March 24, 2022 11:40
pitrou
pitrou approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you @zagto

@pitrou pitrou closed this in 623a15e Mar 24, 2022
@ursabot
Copy link

ursabot commented Mar 24, 2022 •
edited
Loading

Benchmark runs are scheduled for baseline = 7711182 and contender = 623a15e. 623a15e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.54% ⬆️0.04%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.34% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: GLib Component: Parquet Component: Python Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zagto @pitrou @ursabot