Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-16006: [C++][Docs] Provide row conversion example for dynamic schemas #12775

Merged
merged 7 commits into from Jul 6, 2022
Merged

ARROW-16006: [C++][Docs] Provide row conversion example for dynamic schemas #12775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f53f55
Flesh out row conversion API
wjones127 Mar 11, 2022
189100e
chore: respond to basic PR feedback
wjones127 Jun 14, 2022
c4b7a7d
refactor: use RAPIDJSON_HAS_STDSTRING
wjones127 Jun 14, 2022
f2090ef
fix: Add trailing newline
wjones127 Jun 21, 2022
516566d
feat: Move API changes into example
wjones127 Jun 21, 2022
c32ef47
feat: refactor narrative docs
wjones127 Jun 21, 2022
d84ef7f
fix: use static_cast instead of C-style cast
wjones127 Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions cpp/examples/arrow/CMakeLists.txt
View file
Open in desktop
Expand Up @@ -17,6 +17,8 @@

add_arrow_example(row_wise_conversion_example)

add_arrow_example(rapidjson_row_converter)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap in if(ARROW_JSON)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also surprised you don't have to link to rapidjson explicitly…

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think rapidjson is header-only. I didn't see it linked anywhere in CMakeLists for ARROW_JSON.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good to know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, if(ARROW_JSON) would still be good so that this doesn't fail building if RapidJSON wasn't required for building Arrow itself.


if(ARROW_COMPUTE)
add_arrow_example(compute_register_example)
endif()
Expand Down