New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-15819: [R] R docs version switcher doesn't work on Safari on MacOS #12819
Conversation
|
I can confirm the dropdown works on my machine (M1 Mac) too. |
Benchmark runs are scheduled for baseline = ab55bba and contender = aa2e8da. aa2e8da is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Updates the code used in the version switcher to be compatible with Safari, and adds extra docs to the version switcher. Recommendations for reviewing this PR: * You could try building the pkgdown site locally, but the problem there is that the code for constructing the URLs for the dropdown doesn't actually work when loading the page from a file like that * What I do is navigate to a deployed page (I used https://arrow.apache.org/docs/3.0/r/ as there is no version dropdown on that version of the docs) and then open us the JS console in my browser and copy and paste the contents of extra.js into there - you'll then see the dropdown appear and can check the links point to the correct places * The thing we want to check for on this PR is that the dropdown is generated in Safari on MacOS - it wasn't before due to an incompatible regex Closes apache#12819 from thisisnic/ARROW-15819_version_safari Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Updates the code used in the version switcher to be compatible with Safari, and adds extra docs to the version switcher.
Recommendations for reviewing this PR: