ARROW-16233: [Python] [Packaging] test_zoneinfo_tzinfo_to_string fails with zoneinfo._common.ZoneInfoNotFoundError on packaging wheels on Windows #12930
Conversation
|
|
|
@github-actions crossbow submit wheel-windows* |
|
Revision: 9541000 Submitted crossbow builds: ursacomputing/crossbow @ actions-1879
|
|
@github-actions crossbow submit wheel-windows* |
| @@ -83,7 +83,7 @@ RUN choco install -r -y --no-progress python --version=%PYTHON_VERSION% | |||
| RUN python -m pip install -U pip setuptools | |||
|
|
|||
| COPY python/requirements-wheel-build.txt arrow/python/ | |||
| RUN python -m pip install -r arrow/python/requirements-wheel-build.txt | |||
| RUN python -m pip install tzdata -r arrow/python/requirements-wheel-build.txt | |||
There was a problem hiding this comment.
I think the tzdata should be installed in the env for testing the wheel, and shouldn't be required when building.
We do have a python_wheel_windows_test.bat script which I suppose is relevant here.
There was a problem hiding this comment.
And checking the log output, you can indeed already see that the above did not work to install tzdata in the test, because the skip is correctly working: https://github.com/ursacomputing/crossbow/runs/6089209704?check_suite_focus=true#step:7:441
There was a problem hiding this comment.
Great, thanks for the pointers! I wasn't sure where to put it =)
|
Revision: c41670f Submitted crossbow builds: ursacomputing/crossbow @ actions-1880
|
|
Will take a look at hypothesis tests also! 👍 |
|
@github-actions crossbow submit test-conda-python-3.8-hypothesis |
|
@github-actions crossbow submit wheel-windows* |
|
Revision: 2c77087 Submitted crossbow builds: ursacomputing/crossbow @ actions-1881
|
|
Revision: 2c77087 Submitted crossbow builds: ursacomputing/crossbow @ actions-1882
|
|
@github-actions crossbow submit test-conda-python-3.8-hypothesis |
|
@github-actions crossbow submit wheel-windows* |
|
Revision: ca4c9b6 Submitted crossbow builds: ursacomputing/crossbow @ actions-1883
|
|
|
@github-actions crossbow submit wheel-windows* |
|
Revision: ca4c9b6 Submitted crossbow builds: ursacomputing/crossbow @ actions-1884
|
This is probably caused by a race condition, another submission gets that auto incremented build ID earlier. We should remove the auto incremented IDs entirely and use unique hashes instead, e.g.: fyi @raulcd @assignUser |
|
Thanks @kszucs! Linter error is triggered because |
|
Just one thing, a linting error .. |
|
Benchmark runs are scheduled for baseline = 1dccb56 and contender = 36a7f11. 36a7f11 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Trying to fix failing nightly-packaging jobs for windows wheels: