Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16416: [C++] Support cast-function in Substrait #13032

Closed
wants to merge 2 commits into from

Conversation

rtpsw
Copy link
Contributor

@rtpsw rtpsw commented Apr 29, 2022

The cast-function is special in Arrow, because its operation is determined by its output type rather than just by its parameter, and so it requires special handling in Substrait to support it.

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has no components in JIRA, make sure you assign one.

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The general approach described in ARROW-15582 should be general enough to handle cast as well. However, if you have a short term need for "cast" I don't have any problem with this change until we get around to implementing ARROW-15582. Just one minor suggestion.

cpp/src/arrow/engine/substrait/expression_internal.cc Outdated Show resolved Hide resolved
Co-authored-by: Weston Pace <weston.pace@gmail.com>
@ursabot
Copy link

ursabot commented May 5, 2022

Benchmark runs are scheduled for baseline = 3c03d49 and contender = f8d6eac. f8d6eac is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.7% ⬆️0.04%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.35% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f8d6eac3 ec2-t3-xlarge-us-east-2
[Finished] f8d6eac3 test-mac-arm
[Finished] f8d6eac3 ursa-i9-9960x
[Finished] f8d6eac3 ursa-thinkcentre-m75q
[Finished] 3c03d493 ec2-t3-xlarge-us-east-2
[Finished] 3c03d493 test-mac-arm
[Finished] 3c03d493 ursa-i9-9960x
[Finished] 3c03d493 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@rtpsw rtpsw deleted the ARROW-16416 branch June 1, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants