You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrowVectorIterator.hasNext() delegates to the underlying resultset.isAfterLast() method, but per JDBC specs, this should return false in the case of empty ResultSets. This causes hasNext() to return true for empty ResultSets, triggering infinite loops.
ArrowVectorIterator.hasNext() delegates to the underlying resultset.isAfterLast() method, but per JDBC specs, this [should return false in the case of empty ResultSets](https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/ResultSet.html#isAfterLast()). This causes hasNext() to return true for empty ResultSets, triggering infinite loops.
Closes#13049 from toddfarmer/tofarmer/fix-hasnext-for-empty-resultset
Authored-by: Todd Farmer <todd@fivefarmers.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toddfarmer
changed the title
ArrowVectorIterator.hasNext() delegates to the underlying resultset.isAfterLast() method, but per JDBC specs, this should return false in the case of empty ResultSets. This causes hasNext() to return true for empty ResultSets, triggering infinite loops.