Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16497: [R] Update version in NEWS.md #13089

Closed
wants to merge 1 commit into from

Conversation

kou
Copy link
Member

@kou kou commented May 6, 2022

This solves the following CI failure:

https://github.com/apache/arrow/runs/6329293119?check_suite_focus=true

Failure: test_version_pre_tag(PrepareTest)
/home/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:226:in `test_version_pre_tag'
     223:     end
     224:
     225:     prepare("VERSION_PRE_TAG")
  => 226:     assert_equal(expected_changes.sort_by {|diff| diff[:path]},
     227:                  parse_patch(git("log", "-n", "1", "-p")))
     228:   end
     229: end
...
?  {:hunks=>[["-# arrow 8.0.0.9000", "+# arrow 9.0.0"]], :path=>"r/NEWS.md"},
?                       7

This solves the following CI failure:

https://github.com/apache/arrow/runs/6329293119?check_suite_focus=true

    Failure: test_version_pre_tag(PrepareTest)
    /home/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:226:in `test_version_pre_tag'
         223:     end
         224:
         225:     prepare("VERSION_PRE_TAG")
      => 226:     assert_equal(expected_changes.sort_by {|diff| diff[:path]},
         227:                  parse_patch(git("log", "-n", "1", "-p")))
         228:   end
         229: end
    ?  {:hunks=>[["-# arrow 8.0.0.9000", "+# arrow 9.0.0"]], :path=>"r/NEWS.md"},
    ?                       7
@github-actions
Copy link

github-actions bot commented May 6, 2022

@github-actions
Copy link

github-actions bot commented May 6, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@nealrichardson
Copy link
Contributor

Don't we bump all of the versions on master after the release? Any idea why this didn't get handled by that?

@kou
Copy link
Member Author

kou commented May 8, 2022

# arrow 7.0.0.9000 should be updated to # arrow 8.0.0 by dev/release/01-prepare.sh but c3d0312 doesn't include any change for r/NEWS.md.
# arrow 8.0.0.9000 should be added before the updated # arrow 8.0.0 by dev/release/post-12-bump-versions.sh but 4c21fd1 doesn't include any change for r/NEWS.md.

@kszucs Did you get any error when you run dev/release/01-prepare.sh and dev/release/post-12-bump-versions.sh? Or did you get any conflict when you merge these commits?

@kszucs
Copy link
Member

kszucs commented May 8, 2022

I had no errors in neither of the scripts.

@kou
Copy link
Member Author

kou commented May 9, 2022

Ah, I got it.

0,/.../ syntax used in https://github.com/apache/arrow/blob/master/dev/release/utils-prepare.sh#L131-L138 is a GNU sed extension. Sorry.

I'll merge this and fix the problem in a separated pull request to work with sed on macOS.

@kou kou closed this in 26aad14 May 9, 2022
@kou kou deleted the r-news-update branch May 9, 2022 02:24
@kou
Copy link
Member Author

kou commented May 9, 2022

#13095

@ursabot
Copy link

ursabot commented May 10, 2022

Benchmark runs are scheduled for baseline = 953a6de and contender = 26aad14. 26aad14 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.32% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.2% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 26aad143 ec2-t3-xlarge-us-east-2
[Finished] 26aad143 test-mac-arm
[Finished] 26aad143 ursa-i9-9960x
[Finished] 26aad143 ursa-thinkcentre-m75q
[Finished] 953a6ded ec2-t3-xlarge-us-east-2
[Failed] 953a6ded test-mac-arm
[Finished] 953a6ded ursa-i9-9960x
[Finished] 953a6ded ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants