Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16508: [Archery][Dev] Add possibility to extend chat report message based on success or failures of jobs #13102

Closed
wants to merge 2 commits into from

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented May 9, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented May 9, 2022

@raulcd
Copy link
Member Author

raulcd commented May 12, 2022

@kszucs can you take a look on this one?

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look, and all looks reasonable to me. Maybe the --extra-message-success is not that useful since we don't use it ourselves? But also can't hurt to have it I suppose

@amol- amol- closed this in 8411fed May 12, 2022
@raulcd
Copy link
Member Author

raulcd commented May 12, 2022

I took a quick look, and all looks reasonable to me. Maybe the --extra-message-success is not that useful since we don't use it ourselves? But also can't hurt to have it I suppose

I was planning to add a "well done" message!

@ursabot
Copy link

ursabot commented May 13, 2022

Benchmark runs are scheduled for baseline = ee31931 and contender = 8411fed. 8411fed is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.35% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.24% ⬆️0.08%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8411fede ec2-t3-xlarge-us-east-2
[Failed] 8411fede test-mac-arm
[Finished] 8411fede ursa-i9-9960x
[Finished] 8411fede ursa-thinkcentre-m75q
[Finished] ee31931e ec2-t3-xlarge-us-east-2
[Failed] ee31931e test-mac-arm
[Finished] ee31931e ursa-i9-9960x
[Finished] ee31931e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants