Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16529: [Java] Fix ArrowVectorIterator.hasNext() #13107

Conversation

toddfarmer
Copy link
Contributor

Calls to ArrowVectorIterator.hasNext() should return true until ArrowVectorIterator.next() has been called, and the underlying ResultSet has been fully consumed.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@toddfarmer toddfarmer changed the title [Java] Fix ArrowVectorIterator.hasNext() ARROW-16035: [Java] Fix ArrowVectorIterator.hasNext() May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

@lidavidm lidavidm self-requested a review May 10, 2022 14:58
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind making a new Jira ticket for this? You can link the tickets in Jira to represent the relationship.

@toddfarmer toddfarmer changed the title ARROW-16035: [Java] Fix ArrowVectorIterator.hasNext() ARROW-16529: [Java] Fix ArrowVectorIterator.hasNext() May 11, 2022
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm lidavidm closed this in 21de30e May 11, 2022
@ursabot
Copy link

ursabot commented May 13, 2022

Benchmark runs are scheduled for baseline = 9ae12a5 and contender = 21de30e. 21de30e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.12% ⬆️0.04%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.36%] ursa-i9-9960x
[Finished ⬇️1.22% ⬆️0.28%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 21de30e8 ec2-t3-xlarge-us-east-2
[Finished] 21de30e8 test-mac-arm
[Failed] 21de30e8 ursa-i9-9960x
[Finished] 21de30e8 ursa-thinkcentre-m75q
[Finished] 9ae12a56 ec2-t3-xlarge-us-east-2
[Finished] 9ae12a56 test-mac-arm
[Finished] 9ae12a56 ursa-i9-9960x
[Finished] 9ae12a56 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants