Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16534: [Java] update Gandiva protobuf library to enable builds on M1 #13121

Closed
wants to merge 1 commit into from

Conversation

lwhite1
Copy link
Contributor

@lwhite1 lwhite1 commented May 11, 2022

Currently used protobuf library 2.5.0 does not include support for M1, causing tests to fail after compiling from source on Apple Silicon. Version 3.20.1 does provide M1 support. This PR updates the library version.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@lidavidm
Copy link
Member

@pravindra do you want to take a look at this since it affects Gandiva?

@lwhite1 lwhite1 changed the title [JAVA] update Gandiva protobuf library to enable builds on M1 ARROW-16534[JAVA] update Gandiva protobuf library to enable builds on M1 May 11, 2022
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lwhite1 lwhite1 changed the title ARROW-16534[JAVA] update Gandiva protobuf library to enable builds on M1 ARROW-16534: [JAVA] update Gandiva protobuf library to enable builds on M1 May 11, 2022
@kou kou changed the title ARROW-16534: [JAVA] update Gandiva protobuf library to enable builds on M1 ARROW-16534: [Java] update Gandiva protobuf library to enable builds on M1 May 11, 2022
@kou
Copy link
Member

kou commented May 11, 2022

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: c07c296

Submitted crossbow builds: ursacomputing/crossbow @ actions-2068

Task Status
java-jars Github Actions

@lidavidm
Copy link
Member

@Johnnathanalmeida @projjal as active Gandiva contributors, are either of you able to take a look at Gandiva changes here?

Copy link
Contributor

@anthonylouisbsb anthonylouisbsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidavidm I am a Gandiva contributor too and for me it is ok. Also, the github-java-jars job is working.

Approved!

@lidavidm lidavidm closed this in 7341dbc May 13, 2022
@lidavidm
Copy link
Member

Thanks all!

@ursabot
Copy link

ursabot commented May 15, 2022

Benchmark runs are scheduled for baseline = 235767d and contender = 7341dbc. 7341dbc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.54% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.71% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.2% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7341dbcd ec2-t3-xlarge-us-east-2
[Finished] 7341dbcd test-mac-arm
[Finished] 7341dbcd ursa-i9-9960x
[Finished] 7341dbcd ursa-thinkcentre-m75q
[Finished] 235767d2 ec2-t3-xlarge-us-east-2
[Finished] 235767d2 test-mac-arm
[Finished] 235767d2 ursa-i9-9960x
[Finished] 235767d2 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 15, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants