-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-16534: [Java] update Gandiva protobuf library to enable builds on M1 #13121
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format?
or
See also: |
@pravindra do you want to take a look at this since it affects Gandiva? |
|
@github-actions crossbow submit java-jars |
Revision: c07c296 Submitted crossbow builds: ursacomputing/crossbow @ actions-2068
|
@Johnnathanalmeida @projjal as active Gandiva contributors, are either of you able to take a look at Gandiva changes here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lidavidm I am a Gandiva contributor too and for me it is ok. Also, the github-java-jars job is working.
Approved!
Thanks all! |
Benchmark runs are scheduled for baseline = 235767d and contender = 7341dbc. 7341dbc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
Currently used protobuf library 2.5.0 does not include support for M1, causing tests to fail after compiling from source on Apple Silicon. Version 3.20.1 does provide M1 support. This PR updates the library version.