ARROW-16427: [Java] Provide explicit column type mapping #13166
Conversation
| iter.close(); | ||
| } catch (Exception ex) { | ||
| // Fails here due to ARROW-16427: | ||
| // fail("Failed to process ResultSet"); |
There was a problem hiding this comment.
If we don't expect this to fail anymore, should we remove the try-catch (or uncomment the fail) instead of swallowing exceptions?
There was a problem hiding this comment.
It does fail today. My proposal is to break out the task to enable configurable automatic coercion to greater-scale BigDecimals in a separate task. If you agree, I'll open a new task, update the comment to reference that issue, and start work on that after this is closed. This work only allows explicit type mapping via configuration for known-consistent ResultSets. Further work is needed to enable support for inconsistent ResultSets, where scale differs by row.
There was a problem hiding this comment.
Ah, then I misunderstood. Ok, breaking out a separate task for that makes sense.
Can we "xfail" this? I suppose JUnit doesn't support that explicitly but we should assert that it does throw here?
There was a problem hiding this comment.
I moved the comment and failure test around, and have referenced ARROW-16600 (just created to track the configurable coercion work).
toddfarmer
force-pushed
the
toddfarmer/arrow-16427
branch
from
2d8e2b7
to
591008e
Compare
|
Benchmark runs are scheduled for baseline = 3df2e05 and contender = 05bd8fd. 05bd8fd is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
No description provided.