Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-16537: [Java] Patch dataset module testing failure with JSE11+ #13200

Closed
wants to merge 4 commits into from
Closed

ARROW-16537: [Java] Patch dataset module testing failure with JSE11+ #13200

wants to merge 4 commits into from

Conversation

davisusanibar
Copy link
Contributor

Patch dataset module testing failure with JSE11+

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-16537

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

lidavidm
lidavidm approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just some nits.

java/dataset/src/main/java/org/apache/arrow/dataset/jni/DirectReservationListener.java Outdated Show resolved Hide resolved
java/dataset/src/main/java/org/apache/arrow/dataset/jni/DirectReservationListener.java Outdated Show resolved Hide resolved
davisusanibar and others added 2 commits May 20, 2022 10:09
@davisusanibar @lidavidm
Update java/dataset/src/main/java/org/apache/arrow/dataset/jni/Direct…
6edf7aa 
…ReservationListener.java

Co-authored-by: David Li <li.davidm96@gmail.com>
@davisusanibar
Delete method unused
8dd7f75
@lidavidm lidavidm closed this in 442b24b May 23, 2022
@ursabot
Copy link

ursabot commented May 23, 2022

Benchmark runs are scheduled for baseline = d4a7638 and contender = 442b24b. 442b24b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.51% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.74% ⬆️0.37%] ursa-i9-9960x
[Finished ⬇️0.35% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 442b24b0 ec2-t3-xlarge-us-east-2
[Failed] 442b24b0 test-mac-arm
[Failed] 442b24b0 ursa-i9-9960x
[Finished] 442b24b0 ursa-thinkcentre-m75q
[Finished] d4a76384 ec2-t3-xlarge-us-east-2
[Failed] d4a76384 test-mac-arm
[Failed] d4a76384 ursa-i9-9960x
[Finished] d4a76384 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 23, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@lwhite1 lwhite1 mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davisusanibar @ursabot @lidavidm