Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-16704: [JS] Handle case where tableFromIPC input is an async RecordBatchReader #13278

Merged
merged 2 commits into from Jun 1, 2022
Merged

ARROW-16704: [JS] Handle case where tableFromIPC input is an async RecordBatchReader #13278

merged 2 commits into from Jun 1, 2022

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Jun 1, 2022

No description provided.

@trxcllnt trxcllnt requested a review from domoritz June 1, 2022 04:30
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

https://issues.apache.org/jira/browse/ARROW-16704

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

domoritz
domoritz approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Looks good otherwise. Thanks for the fix.

js/test/unit/ipc/serialization-tests.ts Outdated Show resolved Hide resolved
@domoritz domoritz merged commit 5611f2b into apache:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
Component: JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trxcllnt @domoritz