Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-16789: [Format] Remove experimental marker from C Streaming Interface #13345

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

wjones127
Copy link
Member

@wjones127 wjones127 commented Jun 8, 2022

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@wjones127 wjones127 changed the title docs: Remove experimental marker from C Streaming Interface ARROW-16789: [Format] Remove experimental marker from C Streaming Interface Jun 8, 2022
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

@@ -36,8 +36,7 @@
/**
* Functions for working with the C data interface.
* <p>
* This API is EXPERIMENTAL. Note that currently only 64bit systems are
* supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove this here? The fact that the Java API is experimental is a bit unrelated to the status of the C stream interface.
cc @zhztheplayer for opinions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes afaik we don't yet have any codes about C Stream Interface in Java.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sorry I misinterpreted that. I will revert.

@wjones127 wjones127 requested a review from pitrou June 14, 2022 13:41
@wjones127
Copy link
Member Author

(This also resolves https://issues.apache.org/jira/browse/ARROW-14613)

@@ -38,6 +38,7 @@
* <p>
* This API is EXPERIMENTAL. Note that currently only 64bit systems are
* supported.
* Note that currently only 64bit systems are supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was duplicated by mistake? :-)

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wjones127 !

@pitrou pitrou merged commit 9cbb8a1 into apache:master Jun 14, 2022
@wjones127 wjones127 deleted the ARROW-16789-stable-stream-interface branch June 15, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants