ARROW-16865: [C++][Python] Implement cumulative product, max, and min compute functions #13412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for doing this. Will you add unit tests and update related documents? |
cyb70289
changed the title
|
You may consider converting it to draft if this PR is not ready for review now. |
vibhatha
reviewed
Jun 22, 2022
lidavidm
reviewed
Aug 9, 2022
| static constexpr char const kTypeName[] = "CumulativeMinOptions"; | ||
| static CumulativeMinOptions Defaults() { return CumulativeMinOptions(); } | ||
|
|
||
| const bool is_minmax = true; |
There was a problem hiding this comment.
nit: it might be more idiomatic to have this as constexpr static bool, then below use if (OptionsType::is_minmax)
| arr, start=strt, skip_nulls=skip_nulls) | ||
| # Add `start` offset to expected array before comparing | ||
| expected = pc.multiply(expected_arrays[i], strt) | ||
| np.testing.assert_array_almost_equal(result.to_numpy( |
There was a problem hiding this comment.
Are we converting to NumPy here because Arrow doesn't have an approx equals?
|
Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating new compute functions to perform cumulative product, max, and min on a given array.