ARROW-16901: [R][CI] Prune R nightly builds #13453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raulcd could you give this a first pass? |
|
|
kou
reviewed
Jun 28, 2022
kou
reviewed
Jun 29, 2022
assignUser
force-pushed
the
ARROW-16901-Prune-R-nightly-builds
branch
from
0ad8d38
to
f29cccf
Compare
|
Thanks for the review @kou ! While integrating the changes I was already annoyed to do everything twice so I refactored the syncing as a local action. This way it can be easily reused by other components to upload their nightly builds (e.g. java). Here is an example run in a test repo |
kou
reviewed
Jul 1, 2022
raulcd
reviewed
Jul 1, 2022
assignUser
commented
Jul 1, 2022
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
kou
reviewed
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pruning to the nightly R upload, 14 versions will be kept by default.
I have removed the
burnett01/rsync-deploymentsactions because the use of docker for this was unnecessary and the action can only upload to a remote. This new manual version also utilizes host key checking for which I createdsecrets.NIGHTLIES_RSYNC_HOST_KEY(which should contain the result ofssh-keyscan -H nightlies.apache.org 2> /dev/nulland needs to be added to apache/arrow before this can run). This way we are no longer depending on the action and it's associated Dockerfile (drinternet/rsync).We might want to refactor this into a local action for use with all nightly upload jobs.
The pruning is not super efficient as we download the whole nightly repository (on cache miss). This could be avoided for the libarrow files, they could possibly be deleted via ssh instead but we need to download all R packages as
tools::write_PACKAGESneeds access to each archive.