Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17005: [Java] Allow overriding column nullability in arrow-jdbc #13558

Merged
merged 1 commit into from Jul 12, 2022
Merged

ARROW-17005: [Java] Allow overriding column nullability in arrow-jdbc #13558

merged 1 commit into from Jul 12, 2022

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Jul 8, 2022

  • Add nullability to JdbcFieldInfo
  • Refactor tests so that cases that don't require H2/parameterization aren't run repeatedly
  • Make the mock ResultSet adhere to the ResultSet interface better (return null/default values if underlying value is null)

@lidavidm
Copy link
Member Author

lidavidm commented Jul 8, 2022

CC @toddfarmer

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

https://issues.apache.org/jira/browse/ARROW-17005

toddfarmer
toddfarmer approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@toddfarmer toddfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring of the mocks and test code.

@lidavidm lidavidm merged commit 0813544 into apache:master Jul 12, 2022
@lwhite1 lwhite1 mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddfarmer toddfarmer toddfarmer approved these changes

Assignees
No one assigned
Labels
Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lidavidm @toddfarmer