ARROW-17071: [C++][Compute] Fixing off-by-one error in hash join node

[michalursa]

Fixing off-by-one error in hash join node.
Zeroing allocated bit vectors in hash join node to fix another valgrind error.

[michalursa]

@github-actions crossbow submit -g cpp

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17071

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[github-actions]

Revision: 53ad1c2

Submitted crossbow builds: ursacomputing/crossbow @ actions-1d8d74c193

Task	Status
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-debian-10-cpp-amd64
test-debian-10-cpp-i386
test-debian-11-cpp-amd64
test-debian-11-cpp-i386
test-fedora-35-cpp
test-ubuntu-18.04-cpp
test-ubuntu-18.04-cpp-release
test-ubuntu-18.04-cpp-static
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-14
test-ubuntu-20.04-cpp-17
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp

[michalursa]

@github-actions crossbow submit -g cpp

[github-actions]

Revision: 147aadb

Submitted crossbow builds: ursacomputing/crossbow @ actions-206b6227c4

Task	Status
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-debian-10-cpp-amd64
test-debian-10-cpp-i386
test-debian-11-cpp-amd64
test-debian-11-cpp-i386
test-fedora-35-cpp
test-ubuntu-18.04-cpp
test-ubuntu-18.04-cpp-release
test-ubuntu-18.04-cpp-static
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-14
test-ubuntu-20.04-cpp-17
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp

[raulcd]

could the test-ubuntu-20.04-cpp-thread-sanitizer be related to the change? Asking because it is on the asof-join instead of the hash-join : arrow-compute-asof-join-node-test

 SUMMARY: ThreadSanitizer: data race /arrow/cpp/src/arrow/compute/exec/asof_join_node.cc:256:7 in arrow::compute::InputState::Push(std::shared_ptr<arrow::RecordBatch> const&)

[westonpace]

could the test-ubuntu-20.04-cpp-thread-sanitizer be related to the change?

I don't think so. The asof join node has been failing TSAN since before the hash-join code merged. See https://issues.apache.org/jira/browse/ARROW-16964

[westonpace]

Thanks for the fix.

[ursabot]

Benchmark runs are scheduled for baseline = ffd31d8 and contender = abcfbd7. abcfbd7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️2.27% ⬆️2.27%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.7% ⬆️0.21%] test-mac-arm
[Failed ⬇️0.33% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.61% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] abcfbd78 ec2-t3-xlarge-us-east-2
[Failed] abcfbd78 test-mac-arm
[Failed] abcfbd78 ursa-i9-9960x
[Finished] abcfbd78 ursa-thinkcentre-m75q
[Failed] ffd31d8c ec2-t3-xlarge-us-east-2
[Failed] ffd31d8c test-mac-arm
[Failed] ffd31d8c ursa-i9-9960x
[Finished] ffd31d8c ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java