Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17151: [Docs] Pin docs theme to delay dark mode update #13663

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

wjones127
Copy link
Member

The new 0.9 release added changes to enable dark mode and an updated light mode. We likely don't have time to make the necessary adaptions to the style changes, so for now I propose pinning the theme version. ARROW-17152 will follow up and fix any style issues needed to enable the new theme.

I've also included changes to allow building the documentation site without requiring ORC, Parquet Encryption, and Plasma. These are quick fixes and I expect a more robust solution to be implemented in ARROW-17076.

@github-actions
Copy link

@wjones127 wjones127 marked this pull request as draft July 20, 2022 22:41
@wjones127 wjones127 closed this Jul 20, 2022
@wjones127 wjones127 reopened this Jul 20, 2022
@wjones127 wjones127 marked this pull request as ready for review July 21, 2022 00:04
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 8f88088 into apache:master Jul 21, 2022
@ursabot
Copy link

ursabot commented Jul 22, 2022

Benchmark runs are scheduled for baseline = 719d1c0 and contender = 8f88088. 8f88088 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.97% ⬆️0.07%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.39% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 8f880880 ec2-t3-xlarge-us-east-2
[Failed] 8f880880 test-mac-arm
[Failed] 8f880880 ursa-i9-9960x
[Finished] 8f880880 ursa-thinkcentre-m75q
[Failed] 719d1c02 ec2-t3-xlarge-us-east-2
[Failed] 719d1c02 test-mac-arm
[Failed] 719d1c02 ursa-i9-9960x
[Finished] 719d1c02 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants