ARROW-17107: [Java] Fix variable-width vectors in integration JSON writer

[lidavidm]

• Clarify that this is meant to be an internal format
• Fix handling of empty variable-width vectors

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17107

[lwhite1]

If this is intended for integration testing, could it be under the test directory?

[lidavidm]

Integration tests are run via a binary, not via JUnit, so they need to end up in something that gets compiled into a JAR. (Also I'd be a little hesitant to break compatibility immediately here.)

[lwhite1]

One question, which I assume you've already considered. Otherwise looks good. Thank you for all the added testing.

[lwhite1]

Makes perfect sense. Thanks

…

On Thu, Jul 21, 2022 at 1:20 PM David Li ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java <#13676 (comment)>: > @@ -83,8 +84,10 @@ import com.fasterxml.jackson.databind.MappingJsonFactory; /** - * A writer that converts binary Vectors into a JSON format suitable + * A writer that converts binary Vectors into an <em>internal, unstable</em> JSON format suitable Integration tests are run via a binary, not via JUnit, so they need to end up in something that gets compiled into a JAR. (Also I'd be a little hesitant to break compatibility immediately here.) — Reply to this email directly, view it on GitHub <#13676 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2FPAXB467MABONC7CGBW3VVGBFHANCNFSM54HXGXTA> . You are receiving this because you commented.Message ID: ***@***.***>

[jarohen]

Thanks @lidavidm & @lwhite1! 🙏

[ursabot]

Benchmark runs are scheduled for baseline = d584b8d and contender = c2eda76. c2eda76 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.44% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.29% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] c2eda76e ec2-t3-xlarge-us-east-2
[Failed] c2eda76e test-mac-arm
[Failed] c2eda76e ursa-i9-9960x
[Finished] c2eda76e ursa-thinkcentre-m75q
[Failed] d584b8d7 ec2-t3-xlarge-us-east-2
[Failed] d584b8d7 test-mac-arm
[Finished] d584b8d7 ursa-i9-9960x
[Finished] d584b8d7 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java