ARROW-17171: [C++][Gandiva] Implement NextDay Function to case-insensitive #13682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ViniciusSouzaRoque
changed the title
ViniciusSouzaRoque
force-pushed
the
feature/add-nextday-case-insensitive
branch
4 times, most recently
from
7ba4a82
to
6a16ec1
Compare
anthonylouisbsb
suggested changes
Jul 29, 2022
| return 0; \ | ||
| } \ | ||
| \ | ||
| char* up = reinterpret_cast<char*>(gdv_fn_context_arena_malloc(context, in_len)); \ |
There was a problem hiding this comment.
Add a check to see if the malloc operation worked fine
siddhantrao23
approved these changes
Jul 29, 2022
ViniciusSouzaRoque
force-pushed
the
feature/add-nextday-case-insensitive
branch
from
363b835
to
2a78d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing changes for the function to be case-insensitive