ARROW-17191: [C++][FlightRPC] Handle inlined slices after concatenation #13696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the JIRA for details, but essentially: data was getting corrupted since allocating a new
shared_ptr
control block was overwriting the data in aGrpcBuffer
. This happened because the data was inlined into the structure, which we weren't properly accounting for. Instead, copy the data into a new buffer in these cases.I'm not sure why creating a new
shared_ptr
was overlapping an existing allocation, however.