Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17223: [C#] DecimalArray incorrectly appends values greater than Decimal.MaxValue / 2 and less than Decimal.MinValue / 2 #13732

Merged
merged 2 commits into from Jul 28, 2022

Conversation

asmirnov82
Copy link
Contributor

No description provided.

…n Decimal.MaxValue / 2 and less than Decimal.MinValue / 2
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Contributor

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix and the fixups!

I'll merge this once the CI is green.

@eerhardt eerhardt merged commit f645ffa into apache:master Jul 28, 2022
@ursabot
Copy link

ursabot commented Jul 29, 2022

Benchmark runs are scheduled for baseline = 9a00777 and contender = f645ffa. f645ffa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️12.5% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.34% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] f645ffa2 ec2-t3-xlarge-us-east-2
[Finished] f645ffa2 test-mac-arm
[Finished] f645ffa2 ursa-i9-9960x
[Finished] f645ffa2 ursa-thinkcentre-m75q
[Failed] 9a007779 ec2-t3-xlarge-us-east-2
[Finished] 9a007779 test-mac-arm
[Finished] 9a007779 ursa-i9-9960x
[Finished] 9a007779 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jul 29, 2022

['Python', 'R'] benchmarks have high level of regressions.
ec2-t3-xlarge-us-east-2

@asmirnov82 asmirnov82 deleted the arrow-17223-fix-decimal-utility branch July 7, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants