Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17242: [C++][FlightRPC] Propagate RecordBatchReader::Close errors through Flight #13738

Merged
merged 1 commit into from
Jul 29, 2022
Merged

ARROW-17242: [C++][FlightRPC] Propagate RecordBatchReader::Close errors through Flight #13738

merged 1 commit into from
Jul 29, 2022

Conversation

lidavidm
Copy link
Member

No description provided.

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17242

cyb70289
cyb70289 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@cyb70289 cyb70289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyb70289 cyb70289 merged commit fa7e7a3 into apache:master Jul 29, 2022
@ursabot
Copy link

ursabot commented Jul 29, 2022

Benchmark runs are scheduled for baseline = 3e87c66 and contender = fa7e7a3. fa7e7a3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️3.77% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.65% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.54% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] fa7e7a3f ec2-t3-xlarge-us-east-2
[Failed] fa7e7a3f test-mac-arm
[Finished] fa7e7a3f ursa-i9-9960x
[Finished] fa7e7a3f ursa-thinkcentre-m75q
[Failed] 3e87c66a ec2-t3-xlarge-us-east-2
[Finished] 3e87c66a test-mac-arm
[Finished] 3e87c66a ursa-i9-9960x
[Finished] 3e87c66a ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

kszucs pushed a commit that referenced this pull request Jul 29, 2022
@lidavidm @kszucs
ARROW-17242: [C++][FlightRPC] Propagate RecordBatchReader::Close erro…
db2173c 
…rs through Flight (#13738)

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Yibo Cai <yibo.cai@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyb70289 cyb70289 cyb70289 approved these changes

Assignees
No one assigned
Labels
Component: C++ Component: FlightRPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lidavidm @ursabot @cyb70289