Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17272: [Dev] Pass --add-opens in integration tests #13765

Merged
merged 1 commit into from Aug 1, 2022

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Aug 1, 2022

This affects Java 16+ due to JEP 396 which now forces us to pass --add-opens. Detect the presence of Java >8 and pass the flag in the integration runner.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lidavidm, looks good to me. Do you think it is worth to create another JIRA ticket to test the integration tests on a different jdk version too? (17?)

@lidavidm
Copy link
Member Author

lidavidm commented Aug 1, 2022

I'd probably lean towards it being overkill. Unless it can be done inside the existing job somehow, to avoid rebuilding everything?

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit e80981c into apache:master Aug 1, 2022
@ursabot
Copy link

ursabot commented Aug 2, 2022

Benchmark runs are scheduled for baseline = c517318 and contender = e80981c. e80981c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.07% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] e80981ca ec2-t3-xlarge-us-east-2
[Finished] e80981ca test-mac-arm
[Finished] e80981ca ursa-i9-9960x
[Finished] e80981ca ursa-thinkcentre-m75q
[Failed] c5173186 ec2-t3-xlarge-us-east-2
[Finished] c5173186 test-mac-arm
[Finished] c5173186 ursa-i9-9960x
[Finished] c5173186 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants