Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-10600: [Go] Implement Decimal256 #13792

Merged
merged 13 commits into from
Aug 5, 2022
Merged

ARROW-10600: [Go] Implement Decimal256 #13792

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
76d2319
first pass of decimal256
zeroshade Aug 3, 2022
6d02ecb
ipc, arrjson and so on
zeroshade Aug 3, 2022
aa4cfa9
forgot to add the bitWidth to the expected JSON
zeroshade Aug 4, 2022
f85b07b
Update go/arrow/datatype_fixedwidth.go
zeroshade Aug 4, 2022
b6e95e7
Update go/arrow/datatype_fixedwidth.go
zeroshade Aug 4, 2022
21aef6d
changes from review feedback
zeroshade Aug 4, 2022
c47ef3e
check FitsInPrecision when casting scalars
zeroshade Aug 4, 2022
45baa6d
default to decimal128 when missing bitWidth in JSON integration test
zeroshade Aug 4, 2022
bd44686
Merge branch 'master' into arrow-10600-decimal256
zeroshade Aug 5, 2022
d5df467
add missing AppendEmptyValue
zeroshade Aug 5, 2022
0c69de0
add Type method to decimal256
zeroshade Aug 5, 2022
71312b7
error conventions
zeroshade Aug 5, 2022
fe152cc
no more need for unsupportedArrayType
zeroshade Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dev/archery/archery/integration/datagen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1599,8 +1599,7 @@ def _temp_path():

generate_decimal128_case(),

generate_decimal256_case()
.skip_category('Go') # TODO(ARROW-7948): Decimal + Go
generate_decimal256_case()
.skip_category('JS'),

generate_datetime_case(),
Expand Down
2 changes: 1 addition & 1 deletion docs/source/status.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Data Types
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Decimal128 | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Decimal256 | ✓ | ✓ | | | ✓ | | ✓ |
| Decimal256 | ✓ | ✓ | ✓ | | ✓ | | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
| Date32/64 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+
Expand Down
2 changes: 1 addition & 1 deletion go/arrow/array/array.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func init() {
arrow.INTERVAL_MONTHS: func(data arrow.ArrayData) arrow.Array { return NewMonthIntervalData(data) },
arrow.INTERVAL_DAY_TIME: func(data arrow.ArrayData) arrow.Array { return NewDayTimeIntervalData(data) },
arrow.DECIMAL128: func(data arrow.ArrayData) arrow.Array { return NewDecimal128Data(data) },
arrow.DECIMAL256: unsupportedArrayType,
arrow.DECIMAL256: func(data arrow.ArrayData) arrow.Array { return NewDecimal256Data(data) },
arrow.LIST: func(data arrow.ArrayData) arrow.Array { return NewListData(data) },
arrow.STRUCT: func(data arrow.ArrayData) arrow.Array { return NewStructData(data) },
arrow.SPARSE_UNION: func(data arrow.ArrayData) arrow.Array { return NewSparseUnionData(data) },
Expand Down
4 changes: 1 addition & 3 deletions go/arrow/array/array_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func TestMakeFromData(t *testing.T) {
{name: "month_interval", d: arrow.FixedWidthTypes.MonthInterval},
{name: "day_time_interval", d: arrow.FixedWidthTypes.DayTimeInterval},
{name: "decimal128", d: &testDataType{arrow.DECIMAL128}},
{name: "decimal256", d: &testDataType{arrow.DECIMAL256}},
{name: "month_day_nano_interval", d: arrow.FixedWidthTypes.MonthDayNanoInterval},

{name: "list", d: &testDataType{arrow.LIST}, child: []arrow.ArrayData{
Expand Down Expand Up @@ -122,9 +123,6 @@ func TestMakeFromData(t *testing.T) {
{name: "extension", d: &testDataType{arrow.EXTENSION}, expPanic: true, expError: "arrow/array: DataType for ExtensionArray must implement arrow.ExtensionType"},
{name: "extension", d: types.NewUUIDType()},

// unsupported types
{name: "decimal256", d: &testDataType{arrow.DECIMAL256}, expPanic: true, expError: "unsupported data type: DECIMAL256"},

// invalid types
{name: "invalid(-1)", d: &testDataType{arrow.Type(-1)}, expPanic: true, expError: "invalid data type: Type(-1)"},
{name: "invalid(63)", d: &testDataType{arrow.Type(63)}, expPanic: true, expError: "invalid data type: Type(63)"},
Expand Down
3 changes: 3 additions & 0 deletions go/arrow/array/builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,9 @@ func NewBuilder(mem memory.Allocator, dtype arrow.DataType) Builder {
return NewDecimal128Builder(mem, typ)
}
case arrow.DECIMAL256:
if typ, ok := dtype.(*arrow.Decimal256Type); ok {
return NewDecimal256Builder(mem, typ)
}
case arrow.LIST:
typ := dtype.(*arrow.ListType)
return NewListBuilder(mem, typ.Elem())
Expand Down
6 changes: 6 additions & 0 deletions go/arrow/array/compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,9 @@ func Equal(left, right arrow.Array) bool {
case *Decimal128:
r := right.(*Decimal128)
return arrayEqualDecimal128(l, r)
case *Decimal256:
r := right.(*Decimal256)
return arrayEqualDecimal256(l, r)
case *Date32:
r := right.(*Date32)
return arrayEqualDate32(l, r)
Expand Down Expand Up @@ -531,6 +534,9 @@ func arrayApproxEqual(left, right arrow.Array, opt equalOption) bool {
case *Decimal128:
r := right.(*Decimal128)
return arrayEqualDecimal128(l, r)
case *Decimal256:
r := right.(*Decimal256)
return arrayEqualDecimal256(l, r)
case *Date32:
r := right.(*Date32)
return arrayEqualDate32(l, r)
Expand Down
3 changes: 3 additions & 0 deletions go/arrow/array/decimal128_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ func TestNewDecimal128Builder(t *testing.T) {

assert.Equal(t, want, a.Values(), "unexpected Decimal128Values")
assert.Equal(t, []byte{0xb7}, a.NullBitmapBytes()[:1]) // 4 bytes due to minBuilderCapacity
assert.Equal(t, 4, a.Data().Buffers()[0].Len(), "should be 4 bytes due to minBuilderCapacity")
assert.Len(t, a.Values(), 10, "unexpected length of Decimal128Values")
assert.Equal(t, 10*arrow.Decimal128SizeBytes, a.Data().Buffers()[1].Len())

a.Release()
ab.Append(decimal128.FromI64(7))
Expand All @@ -88,6 +90,7 @@ func TestNewDecimal128Builder(t *testing.T) {
assert.Equal(t, 0, a.NullN())
assert.Equal(t, []decimal128.Num{decimal128.FromI64(7), decimal128.FromI64(8)}, a.Values())
assert.Len(t, a.Values(), 2)
assert.Equal(t, 2*arrow.Decimal128SizeBytes, a.Data().Buffers()[1].Len())

a.Release()
}
Expand Down
Loading