ARROW-17276: [Go][Integration] Implement IPC handling for union type #13806
Conversation
|
Pinging @wolfeidau for the last in this series of changes to get Go support for data types :) |
|
Thanks for the lookover @wolfeidau ! |
zeroshade
changed the title
| if arr.Offset == nil { | ||
| offsets = []byte{} |
There was a problem hiding this comment.
It happens in the case of an empty array, which i found when it crashed during archery integration testing lol.
|
|
||
| switch field.Length() { | ||
| case 0: | ||
| buffers = append(buffers, memory.NewBufferBytes([]byte{})) |
There was a problem hiding this comment.
yes. In the case of an empty array the type codes buffer is empty.
| for i, c := range codes { | ||
| if offsets[c] == -1 { | ||
| // offsets are guaranteed to be increasing according to the spec | ||
| // so the first offset we find for a child is the initial offset | ||
| // and will become the "0" for this child. | ||
| offsets[c] = unshiftedOffsets[i] | ||
| shiftedOffsets[i] = 0 | ||
| } else { | ||
| shiftedOffsets[i] = unshiftedOffsets[i] - offsets[c] | ||
| } | ||
| lengths[c] = maxI32(lengths[c], shiftedOffsets[i]+1) | ||
| } |
There was a problem hiding this comment.
Looks great! This may serve as an inspiration for Arrow C++, in turn :-)
|
Benchmark runs are scheduled for baseline = b1d36c0 and contender = d171b6c. d171b6c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
With this, the Go implementation finally fully supports IPC handling for All the Arrow DataTypes!