ARROW-17340: [Go] Use T.TempDir to create temporary test directory

[Juneezee]

A testing cleanup.

This pull request replaces ioutil.TempDir with t.TempDir. We can use the T.TempDir function from the testing package to create temporary directory. The directory created by T.TempDir is automatically removed when the test and all its subtests complete.

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

func TestFoo(t *testing.T) {
	// before
	tmpDir, err := ioutil.TempDir("", "")
	if err != nil {
		t.Fatal(err)
	}
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - How to contribute patches

[zeroshade]

Thanks @Juneezee this is definitely an improvement!

I'll merge this after all the tests succeed. 😄

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17340

[zeroshade]

@Juneezee Looks like there's an issue with Windows here, I think you just need to add a defer o.Close() line 58 of ipc/cmd/arrow-stream-to-file/main_test.go can you give that a try?

I'm guessing it's not "closing" the file opened with ioutil.TempFile and so it's still considered to be "using" the file which is why os.RemoveAll errors.

[zeroshade]

Thanks @Juneezee!

[ursabot]

Benchmark runs are scheduled for baseline = c9ec543 and contender = b1d36c0. b1d36c0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.17% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] b1d36c02 ec2-t3-xlarge-us-east-2
[Failed] b1d36c02 test-mac-arm
[Finished] b1d36c02 ursa-i9-9960x
[Finished] b1d36c02 ursa-thinkcentre-m75q
[Finished] c9ec5438 ec2-t3-xlarge-us-east-2
[Finished] c9ec5438 test-mac-arm
[Finished] c9ec5438 ursa-i9-9960x
[Finished] c9ec5438 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java