-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17367: [C++] Fix the LZ4's CMake target name #13831
Conversation
I changed the LZ4's CMake target name to lz4::lz4 from LZ4::lz4 by ARROW-16614 because I thought that the official LZ4's CMake package uses lz4::lz4 not LZ4::lz4. But I was wrong. The official LZ4's CMake package uses LZ4::lz4 not lz4::lz4: lz4/lz4@f937813
@github-actions crossbow submit -g conan |
|
Revision: ca01751 Submitted crossbow builds: ursacomputing/crossbow @ actions-6e19b5ccb8
|
+1 |
Benchmark runs are scheduled for baseline = 691775d and contender = d11a553. d11a553 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
I changed the LZ4's CMake target name to lz4::lz4 from LZ4::lz4 by ARROW-16614 because I thought that the official LZ4's CMake package uses lz4::lz4 not LZ4::lz4. But I was wrong. The official LZ4's CMake package uses LZ4::lz4 not lz4::lz4: lz4/lz4@f937813 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
I changed the LZ4's CMake target name to lz4::lz4 from LZ4::lz4 by ARROW-16614 because I thought that the official LZ4's CMake package uses lz4::lz4 not LZ4::lz4. But I was wrong. The official LZ4's CMake package uses LZ4::lz4 not lz4::lz4: lz4/lz4@f937813 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
I changed the LZ4's CMake target name to lz4::lz4 from LZ4::lz4 by
ARROW-16614 because I thought that the official LZ4's CMake package
uses lz4::lz4 not LZ4::lz4.
But I was wrong. The official LZ4's CMake package uses LZ4::lz4 not
lz4::lz4:
lz4/lz4@f937813