Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17367: [C++] Fix the LZ4's CMake target name #13831

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

kou
Copy link
Member

@kou kou commented Aug 10, 2022

I changed the LZ4's CMake target name to lz4::lz4 from LZ4::lz4 by
ARROW-16614 because I thought that the official LZ4's CMake package
uses lz4::lz4 not LZ4::lz4.

But I was wrong. The official LZ4's CMake package uses LZ4::lz4 not
lz4::lz4:
lz4/lz4@f937813

I changed the LZ4's CMake target name to lz4::lz4 from LZ4::lz4 by
ARROW-16614 because I thought that the official LZ4's CMake package
uses lz4::lz4 not LZ4::lz4.

But I was wrong. The official LZ4's CMake package uses LZ4::lz4 not
lz4::lz4:
lz4/lz4@f937813
@kou
Copy link
Member Author

kou commented Aug 10, 2022

@github-actions crossbow submit -g conan

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@github-actions
Copy link

Revision: ca01751

Submitted crossbow builds: ursacomputing/crossbow @ actions-6e19b5ccb8

Task Status
conan-maximum Github Actions
conan-minimum Github Actions

@kou
Copy link
Member Author

kou commented Aug 12, 2022

+1

@kou kou merged commit d11a553 into apache:master Aug 12, 2022
@kou kou deleted the cpp-fix-lz4-target-name branch August 12, 2022 04:59
@ursabot
Copy link

ursabot commented Aug 12, 2022

Benchmark runs are scheduled for baseline = 691775d and contender = d11a553. d11a553 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.1% ⬆️0.0%] test-mac-arm
[Failed ⬇️2.47% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d11a5537 ec2-t3-xlarge-us-east-2
[Finished] d11a5537 test-mac-arm
[Failed] d11a5537 ursa-i9-9960x
[Finished] d11a5537 ursa-thinkcentre-m75q
[Finished] 691775d9 ec2-t3-xlarge-us-east-2
[Failed] 691775d9 test-mac-arm
[Failed] 691775d9 ursa-i9-9960x
[Finished] 691775d9 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 12, 2022

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
I changed the LZ4's CMake target name to lz4::lz4 from LZ4::lz4 by
ARROW-16614 because I thought that the official LZ4's CMake package
uses lz4::lz4 not LZ4::lz4.

But I was wrong. The official LZ4's CMake package uses LZ4::lz4 not
lz4::lz4:
lz4/lz4@f937813

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ksuarez1423 pushed a commit to ksuarez1423/arrow that referenced this pull request Aug 15, 2022
I changed the LZ4's CMake target name to lz4::lz4 from LZ4::lz4 by
ARROW-16614 because I thought that the official LZ4's CMake package
uses lz4::lz4 not LZ4::lz4.

But I was wrong. The official LZ4's CMake package uses LZ4::lz4 not
lz4::lz4:
lz4/lz4@f937813

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants