ARROW-16993: [C++] cmake: cannot create imported target "Boost::headers"
#13845
Conversation
|
|
|
Revision: 57bdb36 Submitted crossbow builds: ursacomputing/crossbow @ actions-28f9432361
|
| COMPONENTS | ||
| system | ||
| filesystem | ||
| ${ARROW_BOOST_COMPONENTS} |
There was a problem hiding this comment.
We can specify empty COMPONENTS like #13846.
There was a problem hiding this comment.
What is the advantage of your approach? The COMPONENTS arg completely missing or being empty has the same effect as if(ARG_COMPONENTS) will be false.
There was a problem hiding this comment.
(also sorry for just opening a PR for a ticket you are assigned to. This issue was preventing us from submitting the R package to CRAN so we needed a fix fast and wanted to merge it back now)
There was a problem hiding this comment.
Yes. Both approaches have the same effect.
I think that the empty COMPONENTS approach is easiar to read. Putting the COMPONENTS keyword by a variable expansion may be a bit tricky.
If you like your approach, could you use ARROW_BOOST_COMPONENTS_ARGS or something instead of ARROW_BOOST_COMPONENTS for the variable name? Because the COMPONENTS keyword isn't a component.
There was a problem hiding this comment.
Like @kou I would find COMPONENTS ${ARROW_BOOST_COMPONENTS} to be slightly more explicit.
| COMPONENTS | ||
| system | ||
| filesystem | ||
| ${ARROW_BOOST_COMPONENTS} |
There was a problem hiding this comment.
Yes. Both approaches have the same effect.
I think that the empty COMPONENTS approach is easiar to read. Putting the COMPONENTS keyword by a variable expansion may be a bit tricky.
If you like your approach, could you use ARROW_BOOST_COMPONENTS_ARGS or something instead of ARROW_BOOST_COMPONENTS for the variable name? Because the COMPONENTS keyword isn't a component.
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
@github-actions crossbow submit -g cpp |
No description provided.