ARROW-17386: [R] strptime tests not robust across platforms

[rok]

This is to resolve ARROW-17386.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-17386

[nealrichardson]

The other thing I'd like to see is assertions that the result of strptime is not all NA. My guess about the CRAN issue is that we're testing a token that isn't supported anywhere else (in both R and Arrow), and the difference on his machine is that it does parse successfully in R bust still not in Arrow.

[kou]

You may want to export arrow::internal::kStrptimeSupportsZone as a public API and use it: https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/value_parsing.h#L774

[rok]

You may want to export arrow::internal::kStrptimeSupportsZone as a public API and use it: https://github.com/apache/arrow/blob/master/cpp/src/arrow/util/value_parsing.h#L774

That's a good point! However lubridate's strptime supports %Z flag for strftime only (see docs), so I don't think we need kStrptimeSupportsZone for this change. I opened ARROW-17398 to not lose the idea.

[rok]

Thanks for the review @nealrichardson ! I've addressed your comments and I think this is ready for another review round.

[rok]

CI issues don't seem related.

[ursabot]

Benchmark runs are scheduled for baseline = 6c675c3 and contender = 4ae26d1. 4ae26d1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.41% ⬆️0.07%] test-mac-arm
[Failed ⬇️0.56% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4ae26d1b ec2-t3-xlarge-us-east-2
[Finished] 4ae26d1b test-mac-arm
[Failed] 4ae26d1b ursa-i9-9960x
[Finished] 4ae26d1b ursa-thinkcentre-m75q
[Finished] 6c675c35 ec2-t3-xlarge-us-east-2
[Finished] 6c675c35 test-mac-arm
[Failed] 6c675c35 ursa-i9-9960x
[Finished] 6c675c35 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[ursabot]

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

[rok]

@jonkeane We only change the test here. Is the regression misattributed or are these tests used in tcph or <insert third option>?