Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17423: [CI][C++] Fix building CUDA docker images #13896

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented Aug 16, 2022

  • Update the CUDA runtime version as CUDA 9.1 images are not available anymore
  • Fix passing child command arguments to "docker run"

Checked locally under a Ubuntu 20.04 host with:

UBUNTU=18.04 archery --debug docker run ubuntu-cuda-cpp
UBUNTU=20.04 archery --debug docker run ubuntu-cuda-cpp

@pitrou pitrou requested a review from kszucs August 16, 2022 12:18
@pitrou
Copy link
Member Author

pitrou commented Aug 16, 2022

cc @assignUser

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on. Looks good with a minor change to rsplit. We should test it with some windows and linux jobs.

dev/archery/archery/docker/core.py Outdated Show resolved Hide resolved
ARROW_CUDA: "ON"
ARROW_GANDIVA: "OFF"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is to reduce build times and focus this on CUDA? 👍 Good idea!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@pitrou
Copy link
Member Author

pitrou commented Aug 16, 2022

@kkraus14 Would you like to take a quick look?

.env Outdated
@@ -54,7 +54,7 @@ UBUNTU=20.04

# Default versions for various dependencies
CLANG_TOOLS=12
CUDA=9.1
CUDA=11.4.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may make sense to pick the oldest supported version here instead of this so that someone doesn't accidentally use a feature introduced in a newer driver version and allow it to slip through CI.

Copy link
Member Author

@pitrou pitrou Aug 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would seem to be 11.0.3 for Ubuntu 20.04. Does it make sense @kkraus14 ?
(note that this variable will have to be overriden depending on the Ubuntu version selected, anyway)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Ubuntu 20.04 that makes sense, if we could use 18.04 I would suggest going with 10.0 instead.

I would hope that everyone is using a 11.0+ driver today though.

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Update the CUDA runtime version as CUDA 9.1 images are not available anymore
* Fix passing child command arguments to "docker run"

Checked locally under a Ubuntu 20.04 host with:
```
UBUNTU=18.04 archery --debug docker run ubuntu-cuda-cpp
UBUNTU=20.04 archery --debug docker run ubuntu-cuda-cpp
```
@pitrou pitrou merged commit f6127fc into apache:master Aug 17, 2022
@pitrou pitrou deleted the ARROW-17423-cpp-cuda-ci branch August 17, 2022 09:00
@ursabot
Copy link

ursabot commented Aug 17, 2022

Benchmark runs are scheduled for baseline = 050876c and contender = f6127fc. f6127fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️50.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️9.08% ⬆️7.93%] test-mac-arm
[Failed ⬇️7.4% ⬆️8.22%] ursa-i9-9960x
[Finished ⬇️9.82% ⬆️8.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f6127fca ec2-t3-xlarge-us-east-2
[Finished] f6127fca test-mac-arm
[Failed] f6127fca ursa-i9-9960x
[Finished] f6127fca ursa-thinkcentre-m75q
[Finished] 050876c5 ec2-t3-xlarge-us-east-2
[Failed] 050876c5 test-mac-arm
[Failed] 050876c5 ursa-i9-9960x
[Finished] 050876c5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 17, 2022

['Python', 'R'] benchmarks have high level of regressions.
ec2-t3-xlarge-us-east-2
test-mac-arm
ursa-i9-9960x

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
* Update the CUDA runtime version as CUDA 9.1 images are not available anymore
* Fix passing child command arguments to "docker run"

Checked locally under a Ubuntu 20.04 host with:
```
UBUNTU=18.04 archery --debug docker run ubuntu-cuda-cpp
UBUNTU=20.04 archery --debug docker run ubuntu-cuda-cpp
```

Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants