-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17423: [CI][C++] Fix building CUDA docker images #13896
Conversation
cc @assignUser |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on. Looks good with a minor change to rsplit
. We should test it with some windows and linux jobs.
ARROW_CUDA: "ON" | ||
ARROW_GANDIVA: "OFF" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is to reduce build times and focus this on CUDA? 👍 Good idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
@kkraus14 Would you like to take a quick look? |
.env
Outdated
@@ -54,7 +54,7 @@ UBUNTU=20.04 | |||
|
|||
# Default versions for various dependencies | |||
CLANG_TOOLS=12 | |||
CUDA=9.1 | |||
CUDA=11.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may make sense to pick the oldest supported version here instead of this so that someone doesn't accidentally use a feature introduced in a newer driver version and allow it to slip through CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would seem to be 11.0.3 for Ubuntu 20.04. Does it make sense @kkraus14 ?
(note that this variable will have to be overriden depending on the Ubuntu version selected, anyway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Ubuntu 20.04 that makes sense, if we could use 18.04 I would suggest going with 10.0 instead.
I would hope that everyone is using a 11.0+ driver today though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update the CUDA runtime version as CUDA 9.1 images are not available anymore * Fix passing child command arguments to "docker run" Checked locally under a Ubuntu 20.04 host with: ``` UBUNTU=18.04 archery --debug docker run ubuntu-cuda-cpp UBUNTU=20.04 archery --debug docker run ubuntu-cuda-cpp ```
ccaad19
to
a4e051a
Compare
Benchmark runs are scheduled for baseline = 050876c and contender = f6127fc. f6127fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
* Update the CUDA runtime version as CUDA 9.1 images are not available anymore * Fix passing child command arguments to "docker run" Checked locally under a Ubuntu 20.04 host with: ``` UBUNTU=18.04 archery --debug docker run ubuntu-cuda-cpp UBUNTU=20.04 archery --debug docker run ubuntu-cuda-cpp ``` Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
Checked locally under a Ubuntu 20.04 host with: