ARROW-17496: [Go] Fix Nightly Build #13943
Conversation
|
@github-actions crossbow submit verify-rc-source-go-* |
|
|
Revision: 1a9f33c Submitted crossbow builds: ursacomputing/crossbow @ actions-652af61a88
|
|
@github-actions crossbow submit verify-rc-source-integration-* |
|
Revision: 1a9f33c Submitted crossbow builds: ursacomputing/crossbow @ actions-42a6bfa674
|
|
Revision: 1a9f33c Submitted crossbow builds: ursacomputing/crossbow @ actions-d2e6be8659
|
|
The failing |
|
@github-actions crossbow submit verify-rc-source-integration-macos-conda-amd64 |
|
Revision: 1a9f33c Submitted crossbow builds: ursacomputing/crossbow @ actions-f4984f7e08
|
I recall seeing this test time out before but I am not sure whether it is tracked. I do not think is related to the fix. |
|
Benchmark runs are scheduled for baseline = 62461b0 and contender = 0600bb2. 0600bb2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Turns out that the `pragma_table_info` function in modernc.org/sqlite's package doesn't work correctly in go1.17 either, only in go1.18. As this is only used for testing and the example sqlite flightsql server, rather than anything needed in the flightsql package itself, the bulid failure is easily solved by marking the example and its tests to be only built in go1.18. As we already have a git workflow that runs with go1.18, the CI will still continue to test the example code, but mamba builds using go1.17 won't break anymore. Authored-by: Matt Topol <zotthewizard@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Turns out that the `pragma_table_info` function in modernc.org/sqlite's package doesn't work correctly in go1.17 either, only in go1.18. As this is only used for testing and the example sqlite flightsql server, rather than anything needed in the flightsql package itself, the bulid failure is easily solved by marking the example and its tests to be only built in go1.18. As we already have a git workflow that runs with go1.18, the CI will still continue to test the example code, but mamba builds using go1.17 won't break anymore. Authored-by: Matt Topol <zotthewizard@gmail.com> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Turns out that the
pragma_table_infofunction in modernc.org/sqlite's package doesn't work correctly in go1.17 either, only in go1.18. As this is only used for testing and the example sqlite flightsql server, rather than anything needed in the flightsql package itself, the bulid failure is easily solved by marking the example and its tests to be only built in go1.18.As we already have a git workflow that runs with go1.18, the CI will still continue to test the example code, but mamba builds using go1.17 won't break anymore.