Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: [R] Remove trailing whitespace in flight tests #13952

Merged
merged 1 commit into from
Aug 24, 2022
Merged

MINOR: [R] Remove trailing whitespace in flight tests #13952

merged 1 commit into from
Aug 24, 2022

Conversation

paleolimbot
Copy link
Member

After #13267 there is some trailing whitespace left over in one of the files.

kou
kou approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 3c13dc4 into apache:master Aug 24, 2022
@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = 9b23a70 and contender = 3c13dc4. 3c13dc4 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3c13dc4e ec2-t3-xlarge-us-east-2
[Failed] 3c13dc4e test-mac-arm
[Failed] 3c13dc4e ursa-i9-9960x
[Failed] 3c13dc4e ursa-thinkcentre-m75q
[Finished] 9b23a707 ec2-t3-xlarge-us-east-2
[Failed] 9b23a707 test-mac-arm
[Failed] 9b23a707 ursa-i9-9960x
[Finished] 9b23a707 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 24, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@paleolimbot paleolimbot deleted the minor-whitespace branch August 25, 2022 12:01
@nealrichardson nealrichardson mentioned this pull request Aug 27, 2022
Merged
anjakefala pushed a commit to anjakefala/arrow that referenced this pull request Aug 31, 2022
@paleolimbot @anjakefala
MINOR: [R] Remove trailing whitespace in flight tests (apache#13952)
157335e 
After apache#13267 there is some trailing whitespace left over in one of the files.

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@paleolimbot @zagto
MINOR: [R] Remove trailing whitespace in flight tests (apache#13952)
00878c9 
After apache#13267 there is some trailing whitespace left over in one of the files.

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paleolimbot @ursabot @kou