Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17510: [CI][C++][Windows][MSVC] Use ccache #13957

Merged
merged 1 commit into from Aug 24, 2022
Merged

ARROW-17510: [CI][C++][Windows][MSVC] Use ccache #13957

merged 1 commit into from Aug 24, 2022

Conversation

kou
Copy link
Member

@kou kou commented Aug 24, 2022

ccache supports MSVC since 4.6.0:

https://ccache.dev/releasenotes.html#_ccache_4_6

Added support for caching calls to Microsoft Visual C++ (MSVC) and
clang-cl (MSVC compatibility for Clang).

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17510

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
ARROW-17510: [CI][C++][Windows][MSVC] Use ccache
e7c3cd9 
ccache supports MSVC since 4.6.0:

https://ccache.dev/releasenotes.html#_ccache_4_6

> Added support for caching calls to Microsoft Visual C++ (MSVC) and
> clang-cl (MSVC compatibility for Clang).

* no ccache: 22m23s: https://github.com/apache/arrow/runs/7983003808
* not cached: 39m35s: https://github.com/kou/arrow/runs/7984875241
* cached: 9m31s: https://github.com/kou/arrow/runs/7985401473
@pitrou
Copy link
Member

pitrou commented Aug 24, 2022

Ah, that's nice.
Note we were using clcache on AppVeyor, we'll probably be able to switch to ccache there too?

@kou
Copy link
Member Author

kou commented Aug 24, 2022 •
edited

Note we were using clcache on AppVeyor, we'll probably be able to switch to ccache there too?

Yes. But it's out-of-scope for this pull request.

@pitrou
Copy link
Member

pitrou commented Aug 24, 2022

Thanks a lot for this @kou !

@pitrou pitrou merged commit 965e761 into apache:master Aug 24, 2022
@kou kou deleted the ci-cpp-windows-ccache branch August 24, 2022 07:33
@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = f93ba4d and contender = 965e761. 965e761 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 965e761b ec2-t3-xlarge-us-east-2
[Failed] 965e761b test-mac-arm
[Failed] 965e761b ursa-i9-9960x
[Failed] 965e761b ursa-thinkcentre-m75q
[Finished] f93ba4da ec2-t3-xlarge-us-east-2
[Failed] f93ba4da test-mac-arm
[Failed] f93ba4da ursa-i9-9960x
[Failed] f93ba4da ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

anjakefala pushed a commit to anjakefala/arrow that referenced this pull request Aug 31, 2022
@kou @anjakefala
ARROW-17510: [CI][C++][Windows][MSVC] Use ccache (apache#13957)
2a5c709 
ccache supports MSVC since 4.6.0:

https://ccache.dev/releasenotes.html#_ccache_4_6

> Added support for caching calls to Microsoft Visual C++ (MSVC) and
> clang-cl (MSVC compatibility for Clang).

* no ccache: 22m23s: https://github.com/apache/arrow/runs/7983003808
* not cached: 39m35s: https://github.com/kou/arrow/runs/7984875241
* cached: 9m31s: https://github.com/kou/arrow/runs/7985401473

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@kou @zagto
ARROW-17510: [CI][C++][Windows][MSVC] Use ccache (apache#13957)
31e3e39 
ccache supports MSVC since 4.6.0:

https://ccache.dev/releasenotes.html#_ccache_4_6

> Added support for caching calls to Microsoft Visual C++ (MSVC) and
> clang-cl (MSVC compatibility for Clang).

* no ccache: 22m23s: https://github.com/apache/arrow/runs/7983003808
* not cached: 39m35s: https://github.com/kou/arrow/runs/7984875241
* cached: 9m31s: https://github.com/kou/arrow/runs/7985401473

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou pitrou approved these changes

Assignees
No one assigned
Labels
Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kou @pitrou @ursabot