Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17527: [Go] Implement Cast to Boolean Functions #13974

Merged
merged 7 commits into from
Aug 29, 2022

Conversation

zeroshade
Copy link
Member

No description provided.

This implements the interface for Kernels along with a `KernelSignature` struct and the type matching for `InputType` and `OutputType` via a `TypeMatcher` interface. Along with tests for all of the above.

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@zeroshade
Copy link
Member Author

zeroshade commented Aug 26, 2022

I'll give this the weekend for others to take a look, and merge it monday if there's no issues.

@zeroshade zeroshade merged commit 9d86755 into apache:master Aug 29, 2022
@zeroshade zeroshade deleted the cast-kernels-boolean branch August 29, 2022 14:46
@ursabot
Copy link

ursabot commented Aug 29, 2022

Benchmark runs are scheduled for baseline = 6f302a3 and contender = 9d86755. 9d86755 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 9d867558 ec2-t3-xlarge-us-east-2
[Failed] 9d867558 test-mac-arm
[Failed] 9d867558 ursa-i9-9960x
[Finished] 9d867558 ursa-thinkcentre-m75q
[Finished] 6f302a30 ec2-t3-xlarge-us-east-2
[Failed] 6f302a30 test-mac-arm
[Failed] 6f302a30 ursa-i9-9960x
[Finished] 6f302a30 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Aug 29, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

anjakefala pushed a commit to anjakefala/arrow that referenced this pull request Aug 31, 2022
Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants