-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17052: [C++][Python][FlightRPC] expose flight structures serialize #13986
ARROW-17052: [C++][Python][FlightRPC] expose flight structures serialize #13986
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I see this is a draft, just some notes
I am checking the issue reported by Travis CI on 03e204c |
Those jobs tend tend to be flaky, if there's not a test failure, it's usually fine |
973365c
to
843d895
Compare
Hi @lidavidm, this MR is ready. Please help with another review when you have time. |
Co-authored-by: David Li <li.davidm96@gmail.com>
843d895
to
2a338d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
CI failures are unrelated. Thanks! |
Benchmark runs are scheduled for baseline = 5e49174 and contender = 7cfdfbb. 7cfdfbb is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…ize (apache#13986) Expose serialize and deserialize for flight structures in C++ and Python: Action, ActionType, Criteria, FlightEndpoint, Result and SchemaResult Notes of no change on Cython binding for: * Criteria and PutResult (FlightClient::DoPutResult) aren't exposed directly * ActionType is implemented with named-tuple Lead-authored-by: Quang Hoang <quanghgx@gmail.com> Co-authored-by: Quang Hoang Xuan <quanghgx@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
…ize (apache#13986) Expose serialize and deserialize for flight structures in C++ and Python: Action, ActionType, Criteria, FlightEndpoint, Result and SchemaResult Notes of no change on Cython binding for: * Criteria and PutResult (FlightClient::DoPutResult) aren't exposed directly * ActionType is implemented with named-tuple Lead-authored-by: Quang Hoang <quanghgx@gmail.com> Co-authored-by: Quang Hoang Xuan <quanghgx@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Expose serialize and deserialize for flight structures in C++ and Python: Action, ActionType, Criteria, FlightEndpoint, Result and SchemaResult
Notes of no change on Cython binding for: