Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17052: [C++][Python][FlightRPC] expose flight structures serialize #13986

Merged
merged 14 commits into from
Sep 15, 2022

Conversation

quanghgx
Copy link
Contributor

@quanghgx quanghgx commented Aug 28, 2022

Expose serialize and deserialize for flight structures in C++ and Python: Action, ActionType, Criteria, FlightEndpoint, Result and SchemaResult

Notes of no change on Cython binding for:

  • Criteria and PutResult (FlightClient::DoPutResult) aren't exposed directly
  • ActionType is implemented with named-tuple

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I see this is a draft, just some notes

cpp/src/arrow/flight/flight_internals_test.cc Show resolved Hide resolved
cpp/src/arrow/flight/types.cc Outdated Show resolved Hide resolved
cpp/src/arrow/flight/types.cc Outdated Show resolved Hide resolved
cpp/src/arrow/flight/types.cc Show resolved Hide resolved
@quanghgx quanghgx marked this pull request as ready for review September 3, 2022 12:02
cpp/src/arrow/flight/flight_internals_test.cc Outdated Show resolved Hide resolved
python/pyarrow/_flight.pyx Outdated Show resolved Hide resolved
@quanghgx
Copy link
Contributor Author

quanghgx commented Sep 7, 2022

I am checking the issue reported by Travis CI on 03e204c

@quanghgx quanghgx marked this pull request as draft September 7, 2022 16:03
@lidavidm
Copy link
Member

lidavidm commented Sep 7, 2022

Those jobs tend tend to be flaky, if there's not a test failure, it's usually fine

python/pyarrow/_flight.pyx Outdated Show resolved Hide resolved
python/pyarrow/_flight.pyx Outdated Show resolved Hide resolved
python/pyarrow/_flight.pyx Outdated Show resolved Hide resolved
@quanghgx quanghgx force-pushed the expose_flight_structures_serialize branch from 973365c to 843d895 Compare September 10, 2022 17:07
@quanghgx quanghgx marked this pull request as ready for review September 11, 2022 03:40
@quanghgx
Copy link
Contributor Author

Hi @lidavidm, this MR is ready. Please help with another review when you have time.
The Travis CI failure (about bloom_filter) seems not related to this MR.
Thank you so much David.

@quanghgx quanghgx force-pushed the expose_flight_structures_serialize branch from 843d895 to 2a338d7 Compare September 12, 2022 11:57
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lidavidm
Copy link
Member

CI failures are unrelated. Thanks!

@lidavidm lidavidm merged commit 7cfdfbb into apache:master Sep 15, 2022
@ursabot
Copy link

ursabot commented Sep 15, 2022

Benchmark runs are scheduled for baseline = 5e49174 and contender = 7cfdfbb. 7cfdfbb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.54% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.56% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.46% ⬆️0.28%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7cfdfbb0 ec2-t3-xlarge-us-east-2
[Failed] 7cfdfbb0 test-mac-arm
[Failed] 7cfdfbb0 ursa-i9-9960x
[Finished] 7cfdfbb0 ursa-thinkcentre-m75q
[Finished] 5e49174d ec2-t3-xlarge-us-east-2
[Finished] 5e49174d test-mac-arm
[Failed] 5e49174d ursa-i9-9960x
[Finished] 5e49174d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
…ize (apache#13986)

Expose serialize and deserialize for flight structures in C++ and Python: Action, ActionType, Criteria, FlightEndpoint, Result and SchemaResult

Notes of no change on Cython binding for:
* Criteria and PutResult (FlightClient::DoPutResult) aren't exposed directly
* ActionType is implemented with named-tuple

Lead-authored-by: Quang Hoang <quanghgx@gmail.com>
Co-authored-by: Quang Hoang Xuan <quanghgx@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
…ize (apache#13986)

Expose serialize and deserialize for flight structures in C++ and Python: Action, ActionType, Criteria, FlightEndpoint, Result and SchemaResult

Notes of no change on Cython binding for:
* Criteria and PutResult (FlightClient::DoPutResult) aren't exposed directly
* ActionType is implemented with named-tuple

Lead-authored-by: Quang Hoang <quanghgx@gmail.com>
Co-authored-by: Quang Hoang Xuan <quanghgx@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants