-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17512: [Doc] Updates to crossbow documentation for clarity #13993
Conversation
…that the default value of off is desired
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format?
or
See also: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general. Just a couple comments.
@lafiona @kevingurney Sorry, I noticed some other items that needed updating as well! (see the comments I posted above) |
…nfigured in this step is Travis CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, this is a nice improvement. Thank you @lafiona @kevingurney
Will wait for CI before merging. |
Benchmark runs are scheduled for baseline = ec714db and contender = 60c9383. 60c9383 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…che#13993) ## Overview While setting up a queue repository for testing changes to `crossbow`, we noticed some updates that can be made to help future developers set up their environment. ## Implementation 1. Clarify Travis CI auto-cancellation default behavior. 2. Fix broken links referenced by instructions. 3. Minor typos. ## Testing 1. Qualified by performing a directory level sphinx build and visually verifying the changes. ## Notes Thank you for your help on this pull request, @kevingurney! Lead-authored-by: Fiona La <fionala7@gmail.com> Co-authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Overview
While setting up a queue repository for testing changes to
crossbow
, we noticed some updates that can be made to help future developers set up their environment.Implementation
Testing
Notes
Thank you for your help on this pull request, @kevingurney!