ARROW-17632: [Python][C++] Add details of where libarrow is being found during build #14059
Conversation
cpp/src/arrow/ArrowConfig.cmake.in
Outdated
| message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}") | ||
| message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}") | ||
| message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}") | ||
| endif() |
There was a problem hiding this comment.
Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?
cpp/src/arrow/ArrowConfig.cmake.in
Outdated
| if(NOT ${PACKAGE_NAME}_FIND_QUIETLY) | ||
| string(TOUPPER ${PACKAGE_NAME} package_name_upper) | ||
| message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}") | ||
| message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}") |
There was a problem hiding this comment.
Does this work with ArrowDataset?
It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))
There was a problem hiding this comment.
The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()
|
Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…nd during build (apache#14059) This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892. Authored-by: Dhruv Vats <dhruv25vats@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…nd during build (apache#14059) This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892. Authored-by: Dhruv Vats <dhruv25vats@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This PR aims to add back
message(STATUS ...)statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.