Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17646: [Go][CI] Switch C Data to use cgo.Handle (bumps to Go1.17) #14067

Merged
merged 5 commits into from
Sep 7, 2022
Merged

ARROW-17646: [Go][CI] Switch C Data to use cgo.Handle (bumps to Go1.17) #14067

merged 5 commits into from
Sep 7, 2022

Conversation

zeroshade
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

https://issues.apache.org/jira/browse/ARROW-17646

@zeroshade zeroshade merged commit 47314c3 into apache:master Sep 7, 2022
@zeroshade zeroshade deleted the cdata-export-stream branch September 7, 2022 22:49
drin pushed a commit to drin/arrow that referenced this pull request Sep 7, 2022
@zeroshade @drin
ARROW-17646: [Go][CI] Switch C Data to use cgo.Handle (bumps to Go1.1…
4abb0db 
…7) (apache#14067)

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@ursabot
Copy link

ursabot commented Sep 8, 2022

Benchmark runs are scheduled for baseline = d123277 and contender = 47314c3. 47314c3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.44% ⬆️0.03%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.11% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 47314c39 ec2-t3-xlarge-us-east-2
[Finished] 47314c39 test-mac-arm
[Failed] 47314c39 ursa-i9-9960x
[Finished] 47314c39 ursa-thinkcentre-m75q
[Finished] d123277b ec2-t3-xlarge-us-east-2
[Finished] d123277b test-mac-arm
[Failed] d123277b ursa-i9-9960x
[Finished] d123277b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold tustvold mentioned this pull request Sep 8, 2022
Closed
@tustvold
Copy link
Contributor

tustvold commented Sep 8, 2022

This appears to have broken the integration tests, as the version of Go in the latest conda-integration image is 1.16. I'm not sure what process kicks off updating this image, but would it be possible for this to be done?

@zeroshade
Copy link
Member Author

@tustvold looks like this would be related to #14069 when that is fixed and merge it should update the conda-integration image.

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@zeroshade @zagto
ARROW-17646: [Go][CI] Switch C Data to use cgo.Handle (bumps to Go1.1…
f41e731 
…7) (apache#14067)

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
@zeroshade @fatemehp
ARROW-17646: [Go][CI] Switch C Data to use cgo.Handle (bumps to Go1.1…
ee4f5ef 
…7) (apache#14067)

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zeroshade @ursabot @tustvold