New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17320: [Python] Refine pyarrow.parquet API exposure #14096
ARROW-17320: [Python] Refine pyarrow.parquet API exposure #14096
Conversation
The only comment I would have is about the linter error. If you have seen it already, please ignore me - I have missed this error in the past and so am adding this just in case.
|
Ah, thanks for that! 👍 I suppose now that it's public, it raises the lint error. I'll wait until it's confirmed we ought to deprecate it in the first place. I was thinking if it was suppose to go away with the legacy dataset, then might not want to rename it just to remove it later. :) |
Yes, exactly.
Makes sense. Let's see what the decision will be - otherwise it could be renamed for a while I guess. |
There is still a doc lint error:
(the Dev lint failure seems unrelated) |
@jorisvandenbossche I think it's okay now, the one failure doesn't seem related. |
Benchmark runs are scheduled for baseline = df7babb and contender = 4d0fbff. 4d0fbff is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Fixes [ARROW-17320](https://issues.apache.org/jira/browse/ARROW-17320?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17577330) Added a deprecation for `_filters_to_expression` -> `filters_to_expression`, in apache@c7fdff3 let me know if that commit should be dropped. :) Authored-by: Miles Granger <miles59923@gmail.com> Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Fixes ARROW-17320
Added a deprecation for
_filters_to_expression
->filters_to_expression
, in c7fdff3 let me know if that commit should be dropped. :)