ARROW-17575: [Docs][C++] Update build document to follow new CMake package #14097
Conversation
|
@github-actions crossbow submit preview-docs |
|
Revision: 1baab6a Submitted crossbow builds: ursacomputing/crossbow @ actions-a611c23cf2
|
|
|
||
| In most cases, it is recommended to use the Arrow shared libraries. | ||
|
|
||
| If Arrow is installed on a custom path instead of a common system one you | ||
| will have to add the path where Arrow is installed to ``CMAKE_PREFIX_PATH``. |
There was a problem hiding this comment.
Could you add examples how to add the path to CMAKE_PREFIX_PATH?
There are 2 ways to add:
cmake ... -DCMAKE_PREFIX_PATH=...: CMake variable: https://cmake.org/cmake/help/latest/variable/CMAKE_PREFIX_PATH.htmlexport CMAKE_PREFIX_PATH=...: Environment variable: https://cmake.org/cmake/help/latest/envvar/CMAKE_PREFIX_PATH.html
I think the latter is better for most cases because the CMAKE_PREFIX_PATH environment variable may be defined in other place.
If we specify cmake -DCMAKE_PREFIX_PATH=${ARROW_ROOT}, the pre-defined CMAKE_PREFIX_PATH environment variable value is ignored. (I didn't confirm it yet but I think so. Sorry.) We can use the pre-defined CMAKE_PREFIX_PATH environment variable value by cmake -DCMAKE_PREFIX_PATH=${ARROW_ROOT}${CMAKE_PREFIX_PATH:+:${CMAKE_PREFIX_PATH}. (${X:+...} is a variable substitution syntax. See also ${parameter:+word} in https://www.gnu.org/software/bash/manual/html_node/Shell-Parameter-Expansion.html . This is used here to not include an empty path such as cmake -DCMAKE_PREFIX_PATH=${ARROW_ROOT}:.)
We can use the variable substitution syntax with export CMAKE_PREFIX_PATH=... case:
export CMAKE_PREFIX_PATH=${ARROW_ROOT}${CMAKE_PREFIX_PATH:+:${CMAKE_PREFIX_PATH}}There was a problem hiding this comment.
Thanks a lot! I've added a couple of examples, let me know if it makes sense or you think there's something more missing.
|
@github-actions crossbow submit preview-docs |
|
Revision: 3f2c76d Submitted crossbow builds: ursacomputing/crossbow @ actions-d4495da68e
|
|
This is how the changes will look like: https://crossbow.voltrondata.com/pr_docs/14097/cpp/build_system.html |
|
Can we make this pull request "Ready for review"? |
|
Benchmark runs are scheduled for baseline = 6cea486 and contender = 6fc33e7. 6fc33e7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…ckage (apache#14097) This is a follow up to update our build documentation from the changes on apache#13892 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…ckage (apache#14097) This is a follow up to update our build documentation from the changes on apache#13892 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This is a follow up to update our build documentation from the changes on #13892