Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17717: [R] Lintr error on CI #14113

Merged
merged 1 commit into from
Sep 14, 2022
Merged

ARROW-17717: [R] Lintr error on CI #14113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions r/tests/testthat/test-dplyr-funcs-type.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,12 +420,12 @@ test_that("type checks with is() giving R types", {
i64_is_chr = is(i64, "character"),
i64_is_fct = is(i64, "factor"),
# we want Arrow to return TRUE, but bit64 returns FALSE
# i64_is_int = is(i64, "integer"),
# i64_is_int = is(i64, "integer"), # nolint
i64_is_i64 = is(i64, "integer64"),
i64_is_lst = is(i64, "list"),
i64_is_lgl = is(i64, "logical"),
# we want Arrow to return TRUE, but bit64 returns FALSE
# i64_is_num = is(i64, "numeric"),
# i64_is_num = is(i64, "numeric"), # nolint
lst_is_chr = is(lst, "character"),
lst_is_fct = is(lst, "factor"),
lst_is_int = is(lst, "integer"),
Expand Down Expand Up @@ -504,10 +504,10 @@ test_that("type checks with is.*()", {
transmute(
i64_is_chr = is.character(i64),
# TODO: investigate why this is not matching when testthat runs it
# i64_is_dbl = is.double(i64),
# i64_is_dbl = is.double(i64), # nolint
i64_is_fct = is.factor(i64),
# we want Arrow to return TRUE, but bit64 returns FALSE
# i64_is_int = is.integer(i64),
# i64_is_int = is.integer(i64), # nolint
i64_is_i64 = is.integer64(i64),
i64_is_lst = is.list(i64),
i64_is_lgl = is.logical(i64),
Expand Down