ARROW-17629: [Java] Bind DB column to Arrow Map type in JdbcToArrowUtils #14134
Conversation
|
|
| @@ -216,7 +216,7 @@ public JdbcToArrowConfigBuilder setTargetBatchSize(int targetBatchSize) { | |||
| * Defaults to wrapping {@link JdbcToArrowUtils#getArrowTypeFromJdbcType(JdbcFieldInfo, Calendar)}. | |||
| */ | |||
| public JdbcToArrowConfigBuilder setJdbcToArrowTypeConverter( | |||
There was a problem hiding this comment.
Is it possible to add an overload to accept a Function still for backwards compatibility?
There was a problem hiding this comment.
Alternatively - we could add the column index as a field in JdbcFieldInfo so that signatures do not have to change
There was a problem hiding this comment.
Thank you for review @lidavidm
JdbcFieldInfo with additional column index is works for me
|
Benchmark runs are scheduled for baseline = fc98c95 and contender = bd433c0. bd433c0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…ils (apache#14134) This pull request allows support of mapping for map type (hstore translated by jdbc driver to java.util.Map or json text/varchar). Mapping for MapConsumer should be manually expressed in new JdbcToArrowConfigBuilder(...).setJdbcToArrowTypeConverter(USER_CUSTOM_jdbcToArrowTypeConverter). Now it possible as part of [ARROW-17630](https://issues.apache.org/jira/browse/ARROW-17630) that allow user to distinguish columns by number and related external metadata. Authored-by: igor.suhorukov <igor.suhorukov@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
…ils (apache#14134) This pull request allows support of mapping for map type (hstore translated by jdbc driver to java.util.Map or json text/varchar). Mapping for MapConsumer should be manually expressed in new JdbcToArrowConfigBuilder(...).setJdbcToArrowTypeConverter(USER_CUSTOM_jdbcToArrowTypeConverter). Now it possible as part of [ARROW-17630](https://issues.apache.org/jira/browse/ARROW-17630) that allow user to distinguish columns by number and related external metadata. Authored-by: igor.suhorukov <igor.suhorukov@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
This pull request allows support of mapping for map type (hstore translated by jdbc driver to java.util.Map or json text/varchar). Mapping for MapConsumer should be manually expressed in new JdbcToArrowConfigBuilder(...).setJdbcToArrowTypeConverter(USER_CUSTOM_jdbcToArrowTypeConverter). Now it possible as part of ARROW-17630 that allow user to distinguish columns by number and related external metadata.